Re: locate-dominating-file calls `stat' too eagerly

[Stefan Monnier]

>> > (defun locate-dominating-file (file regexp)
>> >   "Look up the directory hierarchy from FILE for a file matching REGEXP."
>> >   ;; If FILE does not exist, find its parent directory that does.
>> >   (or (file-exists-p file)
>> >       (while (and file (not (file-directory-p file)))
>> >         (setq file (file-name-directory (directory-file-name file)))))
>> In some corner cases, this can infloop.
> What are those cases?  I think we need to describe them in a comment
> there.

Can't remember, sadly.

>> > And btw, won't the user test cover the case of crossing ~/ as well?
>> In 99% of the cases, yes.
> What are the remaining 1%?  Again, I think they should be mentioned in
> comments.

These are too obvious to be worth mentioning: when the user owns ~/..
The most common such case I can think of is when the user is `root'.


        Stefan