emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: tool-bar related errors when loading compile.el


From: martin rudalics
Subject: Re: tool-bar related errors when loading compile.el
Date: Mon, 06 Oct 2008 11:37:14 +0200
User-agent: Thunderbird 2.0.0.16 (Windows/20080708)

>   >   (if (display-graphic-p)
>       ^^^^^^^^^^^^^^^^^
> Using this in defvars is broken.  If you start with "emacs -nw" and
> later create X11 frames, the defvar will not be initialized correctly
> for X11 frames.
>
>   > into
>   >
>   >   (if tool-bar-mode
>   >
>   > in compile.el and grep.el.
>
> Unfortunately that is not better for the same reason.

So even if we made `compilation-mode-tool-bar-map' a function and did

    (when tool-bar-mode
      (set (make-local-variable 'tool-bar-map)
           (compilation-mode-tool-bar-map)))

in `compilation-mode' we'd miss something?

martin




reply via email to

[Prev in Thread] Current Thread [Next in Thread]