[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: emacsclient's option decoding code
From: |
Chong Yidong |
Subject: |
Re: emacsclient's option decoding code |
Date: |
Sun, 02 Nov 2008 16:45:19 -0500 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) |
Eli Zaretskii <address@hidden> writes:
> I find this code highly confusing to the degree of being
> unmaintainable. Look, for example, how it sets `tty' to zero or
> non-zero, and how this is interleaved with testing whether it is zero
> or non-zero, completely obfuscating the semantics of the code and the
> meaning of each variable.
>
> I think this should be rewritten, but since I cannot make heads or
> tails out of it, I cannot do that myself without risking to break the
> code. Please someone make this code speak to a programmer.
I did what I could to simplify the code (partly by removing the
redundant variable window_system, partly by adding comments).
Hopefully nothing broke. My testing indicates no problems.
- emacsclient's option decoding code, Eli Zaretskii, 2008/11/01
- Re: emacsclient's option decoding code, Stefan Monnier, 2008/11/01
- Re: emacsclient's option decoding code,
Chong Yidong <=
- Re: emacsclient's option decoding code, Juanma Barranquero, 2008/11/02
- Re: emacsclient's option decoding code, Chong Yidong, 2008/11/02
- Re: emacsclient's option decoding code, Juanma Barranquero, 2008/11/02
- Re: emacsclient's option decoding code, Eli Zaretskii, 2008/11/02
- Re: emacsclient's option decoding code, Juanma Barranquero, 2008/11/03
- Re: emacsclient's option decoding code, Eli Zaretskii, 2008/11/03
- Re: emacsclient's option decoding code, Chong Yidong, 2008/11/03
- Re: emacsclient's option decoding code, Eli Zaretskii, 2008/11/03
- Re: emacsclient's option decoding code, Chong Yidong, 2008/11/04
- Re: emacsclient's option decoding code, Juanma Barranquero, 2008/11/06