[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: emacsclient's option decoding code
From: |
Eli Zaretskii |
Subject: |
Re: emacsclient's option decoding code |
Date: |
Mon, 03 Nov 2008 22:06:27 +0200 |
> Date: Mon, 3 Nov 2008 13:12:33 +0100
> From: "Juanma Barranquero" <address@hidden>
> Cc: address@hidden, address@hidden
>
> The following proof-of-concept patch seems to work (at the cost of
> adding windows-specific conditions).
Thanks, but I'd like to look for a cleaner patch, one that doesn't add
new ifdef's.
> --- lisp/server.el 30 Oct 2008 15:50:01 -0000 1.171
> +++ lisp/server.el 3 Nov 2008 12:06:49 -0000
> @@ -631,10 +631,12 @@
> ;; This is a leftover, see above.
> (environment . ,(process-get proc 'env))))
> - (frame (make-frame-on-display
> + (frame (if (eq system-type 'windows-nt)
> + (make-frame params)
> + (make-frame-on-display
> (or display
> (frame-parameter nil 'display)
> (getenv "DISPLAY")
> (error "Please specify display"))
> - params)))
> + params))))
> (server-log (format "%s created" frame) proc)
> (select-frame frame)
>
Here' I think it's unclean that the w32 port has make-frame-on-display
fboundp, but it's dysfunctional when called. If make-frame-on-display
can be made to work on Windows, provided that `display' is nil (or
maybe it should ignore `display' even if non-nil?), that would be a
cleaner and more general change.
- emacsclient's option decoding code, Eli Zaretskii, 2008/11/01
- Re: emacsclient's option decoding code, Stefan Monnier, 2008/11/01
- Re: emacsclient's option decoding code, Chong Yidong, 2008/11/02
- Re: emacsclient's option decoding code, Juanma Barranquero, 2008/11/02
- Re: emacsclient's option decoding code, Chong Yidong, 2008/11/02
- Re: emacsclient's option decoding code, Juanma Barranquero, 2008/11/02
- Re: emacsclient's option decoding code, Eli Zaretskii, 2008/11/02
- Re: emacsclient's option decoding code, Juanma Barranquero, 2008/11/03
- Re: emacsclient's option decoding code,
Eli Zaretskii <=
- Re: emacsclient's option decoding code, Chong Yidong, 2008/11/03
- Re: emacsclient's option decoding code, Eli Zaretskii, 2008/11/03
- Re: emacsclient's option decoding code, Chong Yidong, 2008/11/04
- Re: emacsclient's option decoding code, Juanma Barranquero, 2008/11/06
- Re: emacsclient's option decoding code, Juanma Barranquero, 2008/11/03
- Re: emacsclient's option decoding code, Eli Zaretskii, 2008/11/03
- Re: emacsclient's option decoding code, Juanma Barranquero, 2008/11/06
- Re: emacsclient's option decoding code, Eli Zaretskii, 2008/11/07
- Re: emacsclient's option decoding code, Juanma Barranquero, 2008/11/07
- Re: emacsclient's option decoding code, Juanma Barranquero, 2008/11/07