emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

lisp/progmodes/tcl.el (tcl-filter): shouldn't move point


From: Ivan Shmakov
Subject: lisp/progmodes/tcl.el (tcl-filter): shouldn't move point
Date: Tue, 04 Nov 2008 13:26:01 +0600
User-agent: Gnus/5.11 (Gnus v5.11) Emacs/22.1 (gnu/linux)

        tcl.el reads:

--cut: 
http://cvs.savannah.gnu.org/viewvc/*checkout*/emacs/emacs/lisp/progmodes/tcl.el?revision=1.93--
(defun tcl-filter (proc string)
  (let ((inhibit-quit t))
    (with-current-buffer (process-buffer proc)
      (goto-char (process-mark proc))
      ;; Delete prompt if requested.
      (if (marker-buffer inferior-tcl-delete-prompt-marker)
          (progn
            (delete-region (point) inferior-tcl-delete-prompt-marker)
            (set-marker inferior-tcl-delete-prompt-marker nil)))))
  (comint-output-filter proc string))
--cut: 
http://cvs.savannah.gnu.org/viewvc/*checkout*/emacs/emacs/lisp/progmodes/tcl.el?revision=1.93--

        Thus, the point is moved every time there is a new output from
        Tcl.  Shouldn't it be like the following instead?

--- tcl.el?revision=1.93
+++ tcl.el
@@ -1031,11 +1031,11 @@
 (defun tcl-filter (proc string)
   (let ((inhibit-quit t))
     (with-current-buffer (process-buffer proc)
-      (goto-char (process-mark proc))
       ;; Delete prompt if requested.
       (if (marker-buffer inferior-tcl-delete-prompt-marker)
          (progn
-           (delete-region (point) inferior-tcl-delete-prompt-marker)
+           (delete-region (process-mark proc)
+                          inferior-tcl-delete-prompt-marker)
            (set-marker inferior-tcl-delete-prompt-marker nil)))))
   (comint-output-filter proc string))
 

        If such scrolling is desired, the `comint-move-point-for-output'
        variable could be set non-nil.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]