emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: size of emacs executable after unicode merge


From: Juanma Barranquero
Subject: Re: size of emacs executable after unicode merge
Date: Fri, 28 Nov 2008 17:11:31 +0100

On Thu, Nov 27, 2008 at 12:20, Kenichi Handa <address@hidden> wrote:

> After taking over Chong's experiment, I could reduce the
> size of Emacs executables about 7M bytes.  About 4M bytes
> were actually because of charset mapping tables, and it
> could be reduced by setting up C structure temp_charset_work

Your big patch of 2008-11-27 has caused a change when decoding some
filenames. I've detected it because I have a fix for bug#1433 that
works before your changes, but does not work afterwards.

I'm testing by adding the following line to Fw32_short_file_name:

  filename = ENCODE_FILE (filename);

before the call to GetShortPathName.

Before your changes,

1783      filename = ENCODE_FILE (filename);
(gdb) p filename
$5 = 52759907
(gdb) xstring
$6 = (struct Lisp_String *) 0x3250d60
"c:/acci\303\263n/"
(gdb) next
1786      if (GetShortPathName (SDATA (filename), shortname, MAX_PATH) == 0)
(gdb) p filename
$7 = 52759971
(gdb) xstring
$8 = (struct Lisp_String *) 0x3250da0
"c:/acci\363n/"

After your changes,

1783      filename = ENCODE_FILE (filename);
(gdb) p filename
$5 = 55776275
(gdb) xstring
$6 = (struct Lisp_String *) 0x3531410
"c:/acci\303\263n/"
(gdb) next
1786      if (GetShortPathName (SDATA (filename), shortname, MAX_PATH) == 0)
(gdb) p filename
$7 = 55776339
(gdb) xstring
$8 = (struct Lisp_String *) 0x3531450
"c:/acci n/"

             Juanma




reply via email to

[Prev in Thread] Current Thread [Next in Thread]