Re: size of emacs executable after unicode merge

[Chetan Pandya]

While not directly on this, subject, looking at the isearch code, looks like 
there is some dead code. It would perhaps help to remove such code?

Chetan

Here is a diff with 22.3 isearch.el function isearch-other-meta-char:
diff -u "c:/src/emacs-22.3/lisp/isearch.org.el" 
"c:/src/emacs-22.3/lisp/isearch.el"
--- c:/src/emacs-22.3/lisp/isearch.org.el       Tue Feb 05 10:49:45 2008
+++ c:/src/emacs-22.3/lisp/isearch.el   Sun Nov 30 04:26:23 2008
@@ -1733,40 +1733,11 @@
                (goto-char isearch-point)))
            (isearch-update))
          (search-exit-option
-          (let (window)
-             (isearch-unread-key-sequence keylist)
-             (setq main-event (car unread-command-events))
-
-            ;; If we got a mouse click event, that event contains the
-            ;; window clicked on. maybe it was read with the buffer
-            ;; it was clicked on.  If so, that buffer, not the current one,
-            ;; is in isearch mode.  So end the search in that buffer.
-
-            ;; ??? I have no idea what this if checks for, but it's
-            ;; obviously wrong for the case that a down-mouse event
-            ;; on another window invokes this function.  The event
-            ;; will contain the window clicked on and that window's
-            ;; buffer is certainly not always in Isearch mode.
-            ;;
-            ;; Leave the code in, but check for current buffer not
-            ;; being in Isearch mode for now, until someone tells
-            ;; what it's really supposed to do.
-            ;;
-            ;; --gerd 2001-08-10.
-
-            (if (and (not isearch-mode)
-                     (listp main-event)
-                     (setq window (posn-window (event-start main-event)))
-                     (windowp window)
-                     (or (> (minibuffer-depth) 0)
-                         (not (window-minibuffer-p window))))
-                (save-excursion
-                  (set-buffer (window-buffer window))
-                  (isearch-done)
-                  (isearch-clean-overlays))
-              (isearch-done)
-              (isearch-clean-overlays)
-               (setq prefix-arg arg))))
+          (isearch-unread-key-sequence keylist)
+          (setq main-event (car unread-command-events))
+          (isearch-done)
+          (isearch-clean-overlays)
+          (setq prefix-arg arg))
           (t;; otherwise nil
           (isearch-process-search-string key key)))))
 

Diff finished.  Sat Nov 29 20:34:35 2008