emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Emacs-diffs Digest, Vol 74, Issue 135


From: Juanma Barranquero
Subject: Re: Emacs-diffs Digest, Vol 74, Issue 135
Date: Fri, 30 Jan 2009 14:14:26 +0100

On Fri, Jan 30, 2009 at 13:38, Chong Yidong <address@hidden> wrote:

> Juanma has a patch putting pending_signals in #ifdef SYNC_INPUT, and
> I've just asked him to commit it.

That said, I think that's ugly as hell (I've committed it so Emacs
compiles again).

pending_signals could be defined in lisp.h outside the "#ifdef
SYNC_INPUT", which would save a lot of #ifdefs, with the only side
effect that the variable would be assigned in several situations, but
not used (on non-SYNC_INPUT builds). That's not pretty either, but I
think that's what's done with interrupt_input_pending.

Or we could use a macro to set pending_signals, which would do nothing
in the relevant case.

    Juanma




reply via email to

[Prev in Thread] Current Thread [Next in Thread]