emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: rmail-toggle-header problem


From: Kenichi Handa
Subject: Re: rmail-toggle-header problem
Date: Wed, 18 Feb 2009 15:37:16 +0900

In article <address@hidden>, Glenn Morris <address@hidden> writes:

> (These things will be more traceable and less likely to be overlooked
> if you report them as bugs.)

Ah, sorry.  I at first started to write to emacs-devel as
for the second problem because I'm not sure it's a bug of
rmail-toggle-header, rmail-yank-original, or supercite.
Then, I noticed the first problem, and added that in the
mail.

> Kenichi Handa wrote:

> > When toggled, there's no empty line between header part and
> > body part like this:
> >
> > [...]
> > Sender: address@hidden
> > Errors-To: address@hidden
> > X-RMAIL-ATTRIBUTES: --------
> > Hi,
> > omake prints progress bar using the usual ^M terminal trick.
> > [...]

> I think an example rmail file is needed, please. I tried to reproduce
> this using the quoted message from emacs-devel but could not. (Note
> that rms made some changes in this area very recently.)

I found that this problem is fixed by today's update.

> > And, the first "From ..." line is also shown.  Shouldn't
> > that line be hidden?  At least, C-c C-y (mail-yank-original)
> > signals this error:
> >
> > Mail header "From harsh..." doesn't conform to RFC 822. skipping...

> How are you getting that error? "doesn't conform to RFC 822" only
> seems to be found in supercite.

My mail-citation-hook is (sc-cite-original).  So, yes, the
error is from supercite.  

> Arguably, supercite should be changed instead to be more
> forgiving.

Then, I propose this change (though I don't know if we need
a case-fold-search.

*** supercite.el.~1.69.~        2009-01-05 16:55:22.000000000 +0900
--- supercite.el        2009-02-18 15:35:35.000000000 +0900
***************
*** 704,709 ****
--- 704,710 ----
      ("^\\S +:.*$"                 (sc-mail-fetch-field) nil t)
      ("^$"                         (list 'abort '(step . 0)))
      ("^[ \t]+"                    (sc-mail-append-field))
+     ("^From "                     nil nil t)
      (sc-mail-warn-if-non-rfc822-p (sc-mail-error-in-mail-field))
      (end                          (setq sc-mail-headers-end (point))))
    "Regi frame for glomming mail header information.")

---
Kenichi Handa
address@hidden




reply via email to

[Prev in Thread] Current Thread [Next in Thread]