emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: NS: ns-expand-space / slider in Preferences dialog not functional


From: Stefan Monnier
Subject: Re: NS: ns-expand-space / slider in Preferences dialog not functional
Date: Tue, 10 Mar 2009 11:59:11 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.90 (gnu/linux)

>> >   /* FIXME: Because of the typo below, Qbuffered probably never did
>> >      anything useful, so it might as well be removed. */
>> >   Qbuffered = intern ("bufferd");
>> >   staticpro (&Qbuffered);
>> > ??? Whis is this kept around? 
>> 
>> Feel free to remove such dead code.
>> 
>> >   Qfontsize = intern ("fontsize");
>> >   staticpro (&Qfontsize);
>> > What about this one?
>> 
>> What about it?

> Isn't dealing with font sizes supposed to be cross-platform?
> font.c: font_open_for_lface
> [snip]
> #ifdef HAVE_NS
>       if (size == 0)
>         {
>           Lisp_Object ffsize = get_frame_param(f, Qfontsize);
>           size = NUMBERP (ffsize) ? POINT_TO_PIXEL (XINT (ffsize), f->resy) : 
> 0;
>         }
> #endif

Yes, but I don't know what this piece of code is supposed to do.  It can
probably be removed.


        Stefan




reply via email to

[Prev in Thread] Current Thread [Next in Thread]