[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Get rid of per-frame settings of faces via Xresources
From: |
David Reitter |
Subject: |
Re: Get rid of per-frame settings of faces via Xresources |
Date: |
Mon, 4 May 2009 20:21:03 -0400 |
Well, the subject line was informative enough.
If I interpret you correctly: We've had (some of) that removed in
Aquamacs (back then based on pre Emacs 22.1 code) simply because frame
creation was slowed down tremendously (seconds!) when many faces were
known to Emacs (as is the case when you use color themes and you try
out a bunch of them during the session). I decided not to support X
resources on the Mac (under Carbon) - I don't think anybody missed
it. ]
I'm not sure about X of course.
*** lisp/faces.el 13 Apr 2007 18:24:53 +0100 1.370
--- lisp/faces.el 13 Jul 2007 18:56:06 +0100
***************
*** 320,326 ****
(defun set-face-attributes-from-resources (face frame)
"Set attributes of FACE from X resources for FRAME."
! (when (memq (framep frame) '(x w32 mac))
(dolist (definition face-x-resources)
(let ((attribute (car definition)))
(dolist (entry (cdr definition))
--- 320,326 ----
(defun set-face-attributes-from-resources (face frame)
"Set attributes of FACE from X resources for FRAME."
! (when (eq (framep frame) 'x)
(dolist (definition face-x-resources)
(let ((attribute (car definition)))
(dolist (entry (cdr definition))
***************
*** 1789,1796 ****
(condition-case ()
(progn
(face-spec-set face (face-user-default-spec face) frame)
! (if (memq window-system '(x w32 mac))
! (make-face-x-resource-internal face frame))
(internal-merge-in-global-face face frame))
(error nil)))
;; Apply the attributes specified by frame parameters. This
--- 1789,1796 ----
(condition-case ()
(progn
(face-spec-set face (face-user-default-spec face) frame)
! (if (eq window-system 'x)
! (make-face-x-resource-internal face frame))
(internal-merge-in-global-face face frame))
(error nil)))
;; Apply the attributes specified by frame parameters. This