emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [patch] convert footnote.el to use define-minor-mode


From: Leo
Subject: Re: [patch] convert footnote.el to use define-minor-mode
Date: Sat, 04 Jul 2009 17:03:56 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux)

On 2008-12-13 03:13 +0000, Stefan Monnier wrote:
>> 2008-12-12  Eduard Wiebe  <address@hidden>
>
>>      * mail/footnote.el (footnote-mode): Use define-minor-mode
>>      (footnote-prefix): Use defcustom
>
> Looks very good, thank you.  Except you've renamed footnote-prefix to
> footnote-mode-prefix, which doesn't seem to be worth the trouble (of
> and ChangeLog text should end with ".").
>
>
>         Stefan

On 2008-12-13 23:46 +0000, Eduard Wiebe wrote:
[...]
> Stefan, thank you for comments.
>
> 2008-12-14  Eduard Wiebe  <address@hidden>
>
>       * mail/footnote.el (footnote-mode): Use define-minor-mode.
>       (footnote-prefix): Use defcustom.
>
[...]

May it be possible for this patch to be applied to trunk? The current
footnote leaks a few key bindings globally and it can be a surprise to
see them when in a mode without footnote enabled. Thank you.

-- 
Leo's Emacs uptime: 24 days, 2 hours, 19 minutes, 34 seconds




reply via email to

[Prev in Thread] Current Thread [Next in Thread]