emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Willing to debug bug #3542 (23.0.94; File access via UNC path slow a


From: Eli Zaretskii
Subject: Re: Willing to debug bug #3542 (23.0.94; File access via UNC path slow again under Windows)
Date: Mon, 13 Jul 2009 23:13:20 +0300

> From: Andreas Schwab <address@hidden>
> Cc: address@hidden
> Date: Mon, 13 Jul 2009 21:39:20 +0200
> 
> See allocate_string_data.

Aha.  But it sounds like it's not just me who is confused.  Here's
just two examples:

  From doc.c:

      strp = SDATA (string);
      while (strp < SDATA (string) + SBYTES (string))

  (why not "while *strp"?)

  From fileio.c:

      nm = (unsigned char *) alloca (SBYTES (filename) + 1);
      bcopy (SDATA (filename), nm, SBYTES (filename) + 1);

  (why +1? it potentially accesses memory beyond end of `filename's
  contents)

Anyway, thanks.  I will fix the code I committed.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]