emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Patch: Blunderbuss ".dir-locals.el" raises everything in its path!!


From: Jan Djärv
Subject: Re: Patch: Blunderbuss ".dir-locals.el" raises everything in its path!!
Date: Mon, 20 Jul 2009 11:40:22 +0200
User-agent: Thunderbird 2.0.0.22 (Macintosh/20090605)



Alan Mackenzie skrev:
Hi, Jan!

On Wed, Jul 15, 2009 at 09:55:43AM +0200, Jan Djärv wrote:

Here's a preliminary patch which I think fixes the code, though I've only
tested it briefly.  It seems to work for the case you (Jan) were hit by.

Now, any CC Mode style set by `c-file-style' will leave unchanged those
style variables (e.g. `c-cleanup-list') which have already been given
real values.

I expect and intend that if the `c-file-style' mechanism is used twice,
the second one (in the file's Local Variable section) will prevail over
the first one (in some .dir-locals.el), whilst respecting the non-default
value of `c-cleanup-list'.

Jan, please try it out!


It works if I set c-cleanup-list with customize, but not if it is set in the c-common-mode-hook (using add-to-list).

Here's a better patch, incorporating Yidong's amendments to the
manipulations of `file-local-variables-alist'.  Please try this out!


It works fine. Setting c-cleanup-list in a hook or by customize does the same thing now.

        Jan D.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]