Re: [PATCH] xml-escape-region

[Stefan Monnier]

> +;;;##autoload
> +(defun xml-escape-region (beg end)
> +  (interactive "*r")
> +  (let ((escaped (xml-escape-string (buffer-substring beg end))))
> +    (delete-region beg end)
> +    (insert escaped)))

I'd rather not autoload such a function.  But more importantly, this
implementation is very inefficient.  xml-escape-string itself is rather
inefficient except for short strings; this is OK for its current uses,
but for xml-escape-region it's definitely not good (i.e. only usable for
small regions).


        Stefan