Re: 64-bit compilation and printfs

[Eli Zaretskii]

> From: Adrian Robert <address@hidden>
> Date: Sun, 11 Oct 2009 20:46:27 -0400
> 
> In the course of getting the NS port compiling in 64-bit mode, some  
> other developers and myself discovered some format - arg mismatches in  
> printfs.  XINT and XUINT return EMACS_INT which can be a long under  
> LP64.  I'd like to replace places that use %d in the code with %ld,  
> and cast the argument to (long) to avoid issues in 32-bit mode.  This  
> has been checked in for the NS port; the patch attached here does this  
> in common code.  Does anyone think this should be done differently?   
> Else I'll check it in as well.

This is OK, but please note that you seem to have local changes in
xdisp.c unrelated to the %d issue (see below).  Please don't
accidentally check them in as well.

> --- xdisp.c   10 Oct 2009 16:39:05 -0000      1.1313
> +++ xdisp.c   12 Oct 2009 00:41:06 -0000
> @@ -14128,11 +14128,13 @@ try_window_reusing_current_matrix (w)
>      return 0;
>  
>    /* Can't do this if region may have changed.  */
> +  /*
>    if ((!NILP (Vtransient_mark_mode)
>         && !NILP (current_buffer->mark_active))
>        || !NILP (w->region_showing)
>        || !NILP (Vshow_trailing_whitespace))
>      return 0;
> +  */
>  
>    /* If top-line visibility has changed, give up.  */
>    if (WINDOW_WANTS_HEADER_LINE_P (w)
> @@ -23605,6 +23607,9 @@ note_mouse_highlight (f, x, y)
>    if (! EQ (window, dpyinfo->mouse_face_window)
>        || (part != ON_TEXT && part != ON_MODE_LINE && part != ON_HEADER_LINE
>         && !NILP (dpyinfo->mouse_face_window)))
> +/*  if ((! EQ (window, dpyinfo->mouse_face_window)
> +      || (part != ON_TEXT && part != ON_MODE_LINE && part != ON_HEADER_LINE))
> +       && !NILP (dpyinfo->mouse_face_window))*/
>      clear_mouse_face (dpyinfo);