[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: x-popup-menu
From: |
Chad Brown |
Subject: |
Re: x-popup-menu |
Date: |
Fri, 13 Nov 2009 14:51:45 -0800 |
In order to get menu.c to compile --with-ns, I had to remove some code
that Stefan had marked FIXME. That code was since changed by
davidsweldt:
revision 1.19
date: 2009-11-11 16:26:11 -0800; author: davidswelt; state: Exp;
lines: +2 -6; commitid: SpotPAAAts8c8abu;
menu.c (Fx_popup_menu): Remove left-over debugging code and rename
variables to fix 2009-11-09 change.
the current code builds and seems to run fine with limited testing,
but to address Stefan's FIXME: I just removed the code and the result
also seems to work fine under macosx, with limited testing. I'd be
happy to test further if someone could suggest areas to exercise.
Thanks,
*Chad
--- menu.c 2009-11-13 13:12:46.000000000 -0800
+++ menu.c-y 2009-11-11 01:34:10.000000000 -0800
@@ -1182,13 +1182,8 @@
CHECK_LIVE_WINDOW (window);
f = XFRAME (WINDOW_FRAME (win));
-#ifdef HAVE_NS /* FIXME: Is this necessary?? --Stef */
- xpos = FRAME_COLUMN_WIDTH (f) * WINDOW_LEFT_EDGE_COL (win);
- ypos = FRAME_LINE_HEIGHT (f) * WINDOW_TOP_EDGE_LINE (win);
-#else
xpos = WINDOW_LEFT_EDGE_X (win);
ypos = WINDOW_TOP_EDGE_Y (win);
-#endif
}
else
/* ??? Not really clean; should be CHECK_WINDOW_OR_FRAME,