emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: with-current-buffer "cleanup" bug


From: Stefan Monnier
Subject: Re: with-current-buffer "cleanup" bug
Date: Sat, 14 Nov 2009 13:07:29 -0500
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (gnu/linux)

> If you're wholesale changing `save-excursion + set-buffer' to
> `with-current-buffer', this is wrong.

The change may be wrong, but the original code is wrong too.  Which is
why I'm happily applying the change: when it uncovers a bug, the right
fix is almost always to use some other code because the problem can
appear even with the original code.

> The `with-current-buffer' macro
> does not save point (or mark), so this can lead to code behavior change.
> You need to fix this, or we're likely see a long slow trickle of related
> bugs in the coming weeks and months.

Yes, I'm waiting for those bugs indeed,


        Stefan




reply via email to

[Prev in Thread] Current Thread [Next in Thread]