emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: limit the number of log entries displayed by C-x v l


From: Stefan Monnier
Subject: Re: limit the number of log entries displayed by C-x v l
Date: Sun, 06 Dec 2009 21:12:01 -0500
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (gnu/linux)

> This patch does that.
> OK?

Look OK, just one nit:

> -;; * print-log (files buffer &optional shortlog limit)
> +;; * print-log (files buffer &optional shortlog limit start-revision)

Seen from here, it would make sense to have 

   print-log (files buffer &optional shortlog start-rev end-rev)

instead.  Now admittedly, `end-rev' will often/usually not be known, but
we could allow it to be an integer rather than a string, in order to
specify the number of revisions to show.

That might also make it easier to move to

    incoming = (print-log files buf short 'working-revision 'upstream)
and
    outgoing = (print-log files buf short 'upstream 'working-revision)

In any case, what it means in the short term is to use

   print-log (files buffer &optional shortlog start-revision limit)


-- Stefan




reply via email to

[Prev in Thread] Current Thread [Next in Thread]