emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Better subjects, bodies for commit diff emails?


From: Karl Fogel
Subject: Better subjects, bodies for commit diff emails?
Date: Wed, 13 Jan 2010 14:29:56 -0500
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.91 (gnu/linux)

Our commit diff emails currently have subject lines like this:

"[Emacs-diffs] /srv/bzr/emacs/trunk r99318: Fix gc bug in terminal allocation."

They would be better like this, I think:

"[Emacs-diffs] r99318: Fix gc bug in terminal allocation."

The "/srv/bzr/emacs/trunk" is pretty much wasted space.  Do we even send
commit emails for other branches?  I don't know, but if we don't, then
there's no need to take up space saying the branch; and if we do, then
we could just say "trunk" or "foo" without the "/srv/bzr/emacs/" prefix.

Meanwhile, in the message body, adding some vertical whitepace would
make improve readability.  I'll mark my suggestions below with "###":

  revno: 99318
  committer: Chong Yidong <address@hidden>
  branch nick: trunk
  timestamp: Wed 2010-01-13 13:35:36 -0500
  message:
    Fix gc bug in terminal allocation.
    
    * xterm.c (x_term_init): Avoid garbage-collecting the new terminal
    during call to vendor-specific-keysyms (Bug#5365).
  ### How about a blank line here?  Currently there is not one. ###
  modified:
    src/ChangeLog
    src/xterm.c
  ### And how about a blank line here?  Currently there is not one. ###
  === modified file 'src/ChangeLog'
  --- a/src/ChangeLog   2010-01-13 04:42:45 +0000
  +++ b/src/ChangeLog   2010-01-13 18:35:36 +0000
  ### After this point, there are blank lines between hunks, so all good ##

I don't know what would be involved in fixing these problems.  I presume
a Savannah support request for at least the first, and either a Savannah
SR and/or a patch to some Bazaar tool for the latter.

If people agree that these would be good, I (might :-) ) take a look.

Thoughts?

-Karl




reply via email to

[Prev in Thread] Current Thread [Next in Thread]