emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: GDB on Mac is (NOT) Broken


From: YAMAMOTO Mitsuharu
Subject: Re: GDB on Mac is (NOT) Broken
Date: Sat, 20 Mar 2010 13:10:45 +0900
User-agent: Wanderlust/2.14.0 (Africa) SEMI/1.14.6 (Maruoka) FLIM/1.14.8 (Shijō) APEL/10.6 Emacs/22.3 (sparc-sun-solaris2.8) MULE/5.0 (SAKAKI)

>>>>> On Tue, 16 Mar 2010 18:27:03 +1300, address@hidden (Nick Roberts) said:

>> ***************
>> *** 1769,1774 ****
>> --- 1781,1792 ----
>> (progn
>> (setq output (gdb-concat-output output gud-marker-acc))
>> (setq gud-marker-acc "")))
>> +       (if (not (string-match "\n" gdb-first-output-line))

>            (if (gdb-first-post-prompt)

> would probably also work

I guess you meant "(if gdb-first-prompt", but whichever the variables,
I think its value might be changed in the while-loop in
gud-gdba-marker-filter via annotation handler calls.  If we want to
avoid string-match for most cases, then we can save the original value
at the beginning of the while-loop to some variable (say,
orig-gdb-first-prompt) and use it like this:

  (if (and orig-gdb-first-prompt
           (not (string-match "\n" gdb-first-output-line)))

but it looks too much to me.

BTW, which branch should the patch go to, emacs-23 or trunk?

                                     YAMAMOTO Mitsuharu
                                address@hidden




reply via email to

[Prev in Thread] Current Thread [Next in Thread]