[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] eliminate false positive in compile.el
From: |
Stefan Monnier |
Subject: |
Re: [PATCH] eliminate false positive in compile.el |
Date: |
Thu, 25 Mar 2010 15:24:42 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) |
> === modified file 'lisp/progmodes/compile.el'
> - --- lisp/progmodes/compile.el 2010-03-24 13:41:07 +0000
> +++ lisp/progmodes/compile.el 2010-03-25 03:22:22 +0000
> @@ -262,7 +262,7 @@
> \\(?:-\\([0-9]+\\)?\\(?:\\.\\([0-9]+\\)\\)?\\)?:\
> \\(?: *\\(\\(?:Future\\|Runtime\\)?[Ww]arning\\|W:\\)\\|\
> *\\([Ii]nfo\\(?:\\>\\|rmationa?l?\\)\\|I:\\|instantiated
> from\\|[Nn]ote\\)\\|\
> -\[0-9]?\\(?:[^0-9\n]\\|$\\)\\|[0-9][0-9][0-9]\\)"
> +\[0-9]?\\(?:[^0-9\n]\\)\\|[0-9][0-9][0-9]\\)"
which simplifies to
\[0-9]?[^0-9\n]\\|[0-9][0-9][0-9]\\)"
Could you give some rationale for this change other than just "eliminate
false positive"? I mean, someone went to the trouble to add the
\\(?:...\\|$\\), so there should be a good reason to remove it,
Stefan