Re: MS-Windows build broken in Fmake_network_process

[Helmut Eller]

* Eli Zaretskii [2010-03-27 09:50+0100] writes:

>> From: Helmut Eller <address@hidden>
>> Cc: address@hidden
>> Date: Fri, 26 Mar 2010 22:14:09 +0100
>> 
>> If C-g or some other key is pressed during connect this must be
>> dealt with in some way.  Which the previous code did not do
>> correctly.
>
> Please see my other mail in this thread.  I think your view of what
> happens on Windows when the user presses C-g is at least incomplete.

Yes, right.

> I don't argue about this code's correctness or necessity on Posix
> systems.  I accept your and others' expert knowledge about that.  What
> I'm saying is that this code is unneeded and possibly inappropriate on
> Windows, where most of the system calls and mechanisms involved in
> this issue work in an entirely different way under the hood.
> Therefore, I submit that this code should have never been installed
> unconditionally, at least not without discussing its applicability and
> implications on Windows.

You seem to think that adding lots of #ifdefs is a good solution; I
don't think that.

The code in question is not executed unconditionally.  It's inside an
if(errno==EINTR).  If Windows' connect doesn't return EINTR the code is
still correct and simpler than adding #ifdefs.

Helmut