Re: Building Emacs with MSVC

[Eli Zaretskii]

> Date: Tue, 06 Apr 2010 22:49:27 -0600
> From: Christoph <address@hidden>
> CC: address@hidden
> 
> Also, maybe this is interesting for you Eli: bidi.c failed because MSVC 
> does not support the inline keyword for C files (only for C++ files). 
> __inline is the correct keyword for C files 
> (http://msdn.microsoft.com/en-us/library/z8y1yy88.aspx) in MSVC.

Right, I will look into this.  Maybe I can just remove that attribute,
since the reordering engine is fast enough even in a non-optimized
build, and GCC will inline static functions anyway.  Thanks for
pointing this out.

> The patch is actually for a bug in the existing MSVC makefile in 
> lib-src. I am pretty sure even older versions would not run with this, 
> since nmake fails right away:
> 
> === modified file 'lib-src/makefile.w32-in'
> --- lib-src/makefile.w32-in    2010-04-03 01:54:24 +0000
> +++ lib-src/makefile.w32-in    2010-04-06 03:06:03 +0000
> @@ -195,8 +195,8 @@
>       $(lispsource)term/pc-win.elc \
>       $(lispsource)x-dnd.elc \
>       $(lispsource)term/x-win.elc \
> -    ${lispsource}emacs-lisp/easymenu.elc \
> -    ${lispsource}term/ns-win.elc
> +    $(lispsource)emacs-lisp/easymenu.elc \
> +    $(lispsource)term/ns-win.elc

Yes, braces are a no-no in Windows makefiles.  In any case, we do
still try to support Nmake, even though newer MSVC is not supported.

> > Right.  And since MinGW is available and in pretty good shape, we
> > decided at the time not to invest any effort in MSVC.
> >    
> I agree. MinGW works absolutely fine, so is there even any reason to 
> keep the MSVC stuff around?

Probably not.

> Was MSVC supported earlier than MinGW? I 

Yes.