emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Emacs-diffs] /srv/bzr/emacs/trunk r99848: (compilation-save-buffers


From: Stefan Monnier
Subject: Re: [Emacs-diffs] /srv/bzr/emacs/trunk r99848: (compilation-save-buffers-predicate): New custom variable.
Date: Wed, 07 Apr 2010 15:00:13 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux)

>  ;;;###autoload
> +(defcustom compilation-save-buffers-predicate nil
> +  "The second argument (PRED) passed to `save-some-buffers' before compiling.
> +E.g., one can set this to
> +  (lambda ()
> +    (string-prefix-p my-compilation-root (file-truename (buffer-file-name))))
> +to limit saving to files located under `my-compilation-root'.
> +Note, that, in general, `compilation-directory' cannot be used instead
> +of `my-compilation-root' here."
> +  :type '(choice
> +          (const :tag "Default (save all file-visiting buffers)" nil)
> +          (const :tag "Save all buffers" t)
> +          function)
> +  :group 'compilation)
> +
> +;;;###autoload

- Please don't autoload defcustoms unless you have a *really* good
  reason to do it (and even then, ask permission first).
- I like where this is going, but I'm not sure this is enough.
  Could you explain how you see it being used?
  Could you also explain why `compilation-directory' can't be
  used instead?


-- Stefan




reply via email to

[Prev in Thread] Current Thread [Next in Thread]