PATCH: Compilation Problem variouse CFLAGS missing

[Sascha Wilde]

Hi *,

to get Emacs compiled today I had to make the following tiny patch:

diff -r abb6c05de632 src/Makefile.in
--- a/src/Makefile.in   Sun Apr 11 14:45:59 2010 -0700
+++ b/src/Makefile.in   Mon Apr 12 15:04:16 2010 +0200
@@ -252,7 +252,7 @@
 
 /* C_SWITCH_X_SITE must come before C_SWITCH_X_MACHINE and C_SWITCH_X_SYSTEM
    since it may have -I options that should override those two.  */
-ALL_CFLAGS=-Demacs -DHAVE_CONFIG_H $(MYCPPFLAGS) -I. -I${srcdir} 
$(C_SWITCH_MACHINE) $(C_SWITCH_SYSTEM) $(C_SWITCH_X_SITE) C_SWITCH_X_MACHINE 
C_SWITCH_X_SYSTEM ${CFLAGS_SOUND} ${RSVG_CFLAGS} ${DBUS_CFLAGS} ${GCONF_CFLAGS} 
${CFLAGS} @FREETYPE_CFLAGS@ @FONTCONFIG_CFLAGS@ @LIBOTF_CFLAGS@ 
@M17N_FLT_CFLAGS@ ${DEPFLAGS}
+ALL_CFLAGS=-Demacs -DHAVE_CONFIG_H $(MYCPPFLAGS) -I. -I${srcdir} 
$(C_SWITCH_MACHINE) $(C_SWITCH_SYSTEM) C_SWITCH_X_SITE C_SWITCH_X_MACHINE 
C_SWITCH_X_SYSTEM ${CFLAGS_SOUND} ${RSVG_CFLAGS} ${DBUS_CFLAGS} ${GCONF_CFLAGS} 
${CFLAGS} @FREETYPE_CFLAGS@ @FONTCONFIG_CFLAGS@ @LIBOTF_CFLAGS@ 
@M17N_FLT_CFLAGS@ ${DEPFLAGS}
 ALL_OBJC_CFLAGS=$(ALL_CFLAGS) @GNU_OBJC_CFLAGS@
 
 .SUFFIXES: .m

It works but to be honest the whole line smells a bit fishy to me: these
are regular Make variables like $(C_SWITCH_SYSTEM) intermixed with cpp
macros like C_SWITCH_X_MACHINE and autoconf variables like
@address@hidden  I suspect my hotfix is wrong, as I think the problem
was introduced by a change which should have moved C_SWITCH_X_SITE away
from cpp -- but I'm not the right person to sort this out...

cheers
sascha
-- 
Sascha Wilde : "Ist es nicht schon schlimm genug, dass ICH hier rumtrolle?"
             : (Henning Leise in d.o.c.)