emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Strange code in find-composition-internal


From: Kenichi Handa
Subject: Re: Strange code in find-composition-internal
Date: Mon, 26 Apr 2010 21:09:19 +0900

In article <address@hidden>, Eli Zaretskii <address@hidden> writes:

> This is a fragment from find-composition-internal that attempts to
> find a composition, either static (i.e. defined by a `composition'
> text property) or automatic, near the position POS:

>   if (!find_composition (from, to, &start, &end, &prop, string))
>     {
>       if (!NILP (current_buffer->enable_multibyte_characters)
>         && ! NILP (Vauto_composition_mode)
>         && find_automatic_composition (from, to, &start, &end, &gstring,
>                                        string))
>       return list3 (make_number (start), make_number (end), gstring);
>       return Qnil;
>     }
>   if ((end <= XINT (pos) || start > XINT (pos)))
>     {
>       EMACS_INT s, e;

>       if (find_automatic_composition (from, to, &s, &e, &gstring, string)
>         && (e <= XINT (pos) ? e > end : s < start))
>       return list3 (make_number (start), make_number (end), gstring);
>     }
[...]
> Shouldn't the last line be

>       return list3 (make_number (s), make_number (e), gstring);

You are right.  I've just committed a fix for the trunk.

---
Kenichi Handa
address@hidden




reply via email to

[Prev in Thread] Current Thread [Next in Thread]