emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: PATCH: Fix IDO interaction with uniquify.el


From: Stefan Monnier
Subject: Re: PATCH: Fix IDO interaction with uniquify.el
Date: Wed, 05 May 2010 14:14:17 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux)

>> I confirm the original bug report. I propose here a different fix for
>> both ido and iswitch. It is much simpler and more efficient.
> On the minus side, your patch:
>   - is less generic; Óscar's will work for other packages that do
> dynamic renaming of buffers (yes, there are none on the Emacs
> distribution, but there's a lot of elisp code out there).
>   - makes ido depend on a feature of uniquify, which it didn't before.

Even more problematic: it changes the behavior of uniquify.
Can someone install Oscar's patch?

BTW, I don't understand why his patch changes (defvar ido-cur-list)
and (defvar ido-choice-list) into (defvar ido-cur-list nil)
and (defvar ido-choice-list nil).  These changes aren't necessarily bad,
but I suspect the change is either unneeded or hiding a bug.


        Stefan




reply via email to

[Prev in Thread] Current Thread [Next in Thread]