[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Concerning the new `ido-use-virtual-buffers' feature
From: |
Tassilo Horn |
Subject: |
Re: Concerning the new `ido-use-virtual-buffers' feature |
Date: |
Fri, 28 May 2010 08:21:30 +0200 |
User-agent: |
KMail/1.13.3 (Linux/2.6.34-gentoo; KDE/4.4.3; x86_64; ; ) |
On Friday 28 May 2010 03:45:52 Leo wrote:
Hi Leo,
> > I slightly modified the patch and implemented the wishlist item.
Cool!
> > For buffers, if a let-bound variable can be added in
> > ido-buffers-internal I usually avoid adding it in ido-read-internal.
> >
> > To remove virtual buffers as soon as input matches existing ones, the
> > idea is to build a list of existing buffers (ignored buffers are not
> > included) and then match the input against it in ido-exhibit. My
> > testing is very brief though it seems working fine. Could you test it
> > more thoroughly?
Sure.
> > Also remember to try the toggle virtual buffers key C-o too. Thanks.
What do you mean with this one?
> The can be changed
> @@ -3427,7 +3431,9 @@ for first matching file."
> (if default
> (setq ido-temp-list
> (cons default (delete default ido-temp-list))))
> - (if ido-use-virtual-buffers
> + (if (or (eq ido-use-virtual-buffers 'always)
> + (and (boundp ido-virtual-buffers-enabled)
> + ido-virtual-buffers-enabled))
> (ido-add-virtual-buffers-to-list))
> (run-hooks 'ido-make-buffer-list-hook)
> ido-temp-list))
>
>
> to:
>
> @@ -2736,7 +2739,8 @@ C-x C-f ... C-d enter `dired' on current directory."
> See `ido-use-virtual-buffers' for explanation of virtual buffer."
> (interactive)
> (when (and ido-mode (eq ido-cur-item 'buffer))
> - (setq ido-use-virtual-buffers (not ido-use-virtual-buffers))
> + (setq ido-virtual-buffers-enabled
> + (not ido-virtual-buffers-enabled))
> (setq ido-text-init ido-text)
> (setq ido-exit 'refresh)
> (exit-minibuffer)))
Both of these hunks are in your patch. I've read your mail as if I
could simply delete the @@ -3427,7 +3431,9 @@ part from your patch. I
did that, but then 3 out of 10 hunks fail...
And if I try to apply the original patch without these modifications,
then 4 out of 11 hunks fail.
Could you please compile a new patch agains the current bzr trunk that I
can test?
Bye,
Tassilo
- Re: Concerning the new `ido-use-virtual-buffers' feature, (continued)
Re: Concerning the new `ido-use-virtual-buffers' feature, Leo, 2010/05/27
- Re: Concerning the new `ido-use-virtual-buffers' feature, Tassilo Horn, 2010/05/27
- Re: Concerning the new `ido-use-virtual-buffers' feature, Leo, 2010/05/27
- Re: Concerning the new `ido-use-virtual-buffers' feature, Tassilo Horn, 2010/05/27
- Re: Concerning the new `ido-use-virtual-buffers' feature, Leo, 2010/05/27
- Re: Concerning the new `ido-use-virtual-buffers' feature, Leo, 2010/05/27
- Re: Concerning the new `ido-use-virtual-buffers' feature,
Tassilo Horn <=
- Re: Concerning the new `ido-use-virtual-buffers' feature, Leo, 2010/05/28
- Re: Concerning the new `ido-use-virtual-buffers' feature, Leo, 2010/05/28
- Re: Concerning the new `ido-use-virtual-buffers' feature, Juanma Barranquero, 2010/05/28
- Re: Concerning the new `ido-use-virtual-buffers' feature, Leo, 2010/05/28
- Re: Concerning the new `ido-use-virtual-buffers' feature, Tassilo Horn, 2010/05/28
- Re: Concerning the new `ido-use-virtual-buffers' feature, Leo, 2010/05/29