emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

vc-git-log-incoming


From: Miles Bader
Subject: vc-git-log-incoming
Date: Wed, 02 Jun 2010 17:49:42 +0900

vc-git-log-incoming seems to have a bunch of problems:

 (1) By default, it uses "git log HEAD..XXX", where XXX is
     (vc-git-compute-remote), but this is only correct in some cases,
     because the current branch and the branch being pulled from don't
     necessarily have the same name (it failed on my emacs checkout, for
     instance).

     More correct would be to just use "address@hidden", which should
     use the actual upstream branch; however I think the "@{upstream}"
     feature was only added in git 1.7.0.

 (2) If the user doesn't use the default, it just does "git log YYY",
     where YYY is what the user entered, but this is probably not what's
     wanted; really it should use "HEAD..YYY".

 (3) Most seriously, just using git-log like this doesn't actually give
     a list of what will be pulled, because "git pull" first updates the
     local copy of the remote's branches, whereas "git log" does not.

     I'm not totally sure how to do this correctly -- you can get the
     range of revisions that would be added during pulling (by the
     underlying call to "git fetch") by using "git fetch --dry-run", but
     that's not going to give you a log output....

Thanks,

-miles

-- 
Carefully crafted initial estimates reward you not only with
reduced computational effort, but also with understanding and
increased self-esteem.         -- Numerical methods in C,
  Chapter 9. "Root Finding and Nonlinear Sets of Equations"



reply via email to

[Prev in Thread] Current Thread [Next in Thread]