emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Un-setting HGRCPATH in vc-hg.el problematic


From: Sascha Wilde
Subject: Re: Un-setting HGRCPATH in vc-hg.el problematic
Date: Mon, 28 Jun 2010 13:21:13 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux)

Dan Nicolaescu <address@hidden> wrote:
> Sascha Wilde <address@hidden> writes:
>> HGRCPATH set to an empty string in its environment.  What is the
>> rational of doing so?  The comment states "Avoid localization of
>> messages so we can parse the output." but to my best knowledge the hgrc
>> files are not used to set the localization...
[...]
> This message is probably better sent to address@hidden

As I intended to discuss the rational behind the code and find a more
correct solution I thought the developer list would fit...

>> I'd suggest removing the HGRCPATH='' from the environment.  If there
>> are really configuration options that should be disabled for good
>> reasons in this functions, I'd suggest using the --config option of hg
>> to set them specifically.
>
> If you can suggest exactly what --config options to use, it would be
> very easy to make that change.

I can't make a suggestion like this as long as I don't know what
the intention of setting HGRCPATH='' was in the first place.  As stated
above the comment is misleading as hgrc is not used for any kind of
localization (I wrote "to my best knowledge" but I double checked with
an core Mercurial developer in the meantime).

So at the moment it looks as if the HGRCPATH='' can be simply removed!

But there might be some other reasons (Bug#5846 seems to indicate that)
besides the localization issue for trying to deactivate .hgrc files...

Maybe Chong Yidong knows some details, as he made the last changes to
the code in question?

cheers
ssacha
-- 
Sascha Wilde
Nota bene: wenn Word für Längeres geeignet wäre, würde es schließlich
nicht Word, sondern Sentence, Page oder Article heißen
        -- Matthias Mühlich in dctt



reply via email to

[Prev in Thread] Current Thread [Next in Thread]