Re: stop using P_, __P in header files

[Juanma Barranquero]

On Sun, Jul 4, 2010 at 17:55, Dan Nicolaescu <address@hidden> wrote:

> Yes, they should.  I did not convert the code by hand, but by using
> protoize (which runs the preprocessor) so this is why such prototypes got 
> changed.

OK, committed.

> I'd say we should resync with gnulib.
> protoize made this change, so it was not intentional...

Because of the different syntax in prototypes versus K&R, instead of
LOCALE_PARAM_DECLR we should now use LOCALE_PARAM_PROTO

-memcpy_lowcase (char *dest, const char *src, size_t len)
+memcpy_lowcase (CHAR_T *dest, const CHAR_T *src, size_t len
+               LOCALE_PARAM_PROTO)

-memcpy_uppcase (char *dest, const char *src, size_t len)
+memcpy_uppcase (CHAR_T *dest, const CHAR_T *src, size_t len
+               LOCALE_PARAM_PROTO)

which is a bit weird because it goes against the LOCALE_PARAM* use on
strftime.c. It would be possible to redefine L_P_DECL:

# define LOCALE_PARAM_DECL , __locale_t loc

and keep the old code, but there are other functions in the file that
have not been converted.

As strftime.c is maintained outside of Emacs, I'd suggest just
reverting the change and leaving the K&R code as it was. Seems cleaner
that a mixup of styles.

    Juanma