emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Base patch for bug #5975 (bookmarking from Gnus Article buffer).


From: Thierry Volpiatto
Subject: Re: Base patch for bug #5975 (bookmarking from Gnus Article buffer).
Date: Wed, 14 Jul 2010 12:57:00 +0200
User-agent: Gnus/5.110011 (No Gnus v0.11) Emacs/24.0.50 (gnu/linux)

Eli Zaretskii <address@hidden> writes:

>> From: Thierry Volpiatto <address@hidden>
>> Cc: address@hidden
>> Date: Wed, 14 Jul 2010 12:07:50 +0200
>> 
>> Eli Zaretskii <address@hidden> writes:
>> 
>> >> From: Thierry Volpiatto <address@hidden>
>> >> Cc: address@hidden
>> >> Date: Wed, 14 Jul 2010 11:06:13 +0200
>> >> 
>> >> But i am speaking of the case where contributor's code is modified by 
>> >> Emacs
>> >> developers
>> >
>> > Do you have examples?  I think this is done only rarely, and only when
>> > the patch is very small.
>> 
>> Most of my patchs including the last.
>> See all integration of bookmarking from Gnus/Woman/Man.
>> See also the M-g s command in bookmark.
>
> I don't know where to look in order "to see".  Can you show the patch
> you submitted for Woman and `man' and point to a revno where its
> modified version actually went in?

I think i am wrong for these patchs as i can retrieve initial changes i
made, and then the Stefan's modifications.
So apparently things have been done like i said by stefan:
Commit change of contributor and then commit differents changes on top
of this patch: (Sorry i have not bzr, i search faster with hg)

,----
| changeset:   107919:c022e0b360db
| user:        Stefan Monnier <address@hidden>
| date:        Wed Apr 14 11:07:53 2010 -0400
| summary:     Add a new field `location' to bookmarks for non-file bookmarks.
| 
| changeset:   107904:1cd2a7cffe3a
| user:        Stefan Monnier <address@hidden>
| date:        Mon Apr 12 15:12:36 2010 -0400
| summary:     * bookmark.el (bookmark-insert-location): Handle a nil filename.
| 
| changeset:   107902:0cafb6c11cbc
| user:        Stefan Monnier <address@hidden>
| date:        Mon Apr 12 12:09:47 2010 -0400
| summary:     Clean up last bookmark changes for man/woman/gnus-summary.
| 
| changeset:   107901:fd86e7cd598a
| user:        Thierry Volpiatto <address@hidden>
| date:        Mon Apr 12 11:17:29 2010 -0400
| summary:     Summary: Add bookmark support for man, woman and gnus-summary.
`----

,----
| changeset:   105941:1225b620227b
| user:        Stefan Monnier <address@hidden>
| date:        Fri Nov 20 15:47:26 2009 +0000
| summary:     * bookmark.el (bookmark-search-delay, bookmark-search-prompt): 
New options.
`----

I remember changes have been done in one of my initial patchs but can't
remember which one is it.

-- 
Thierry Volpiatto
Get my Gnupg key:
gpg --keyserver pgp.mit.edu --recv-keys 59F29997 




reply via email to

[Prev in Thread] Current Thread [Next in Thread]