Re: Un-setting HGRCPATH in vc-hg.el problematic

[Dan Nicolaescu]

Sascha Wilde <address@hidden> writes:

> Hi *,
>
> sorry for the extreme late reply...
>
> Anyway, I created a patch which hopefully resolves my issues while not
> reintroducing any of the old ones.
>
> Dan Nicolaescu <address@hidden> wrote:
>> Sascha Wilde <address@hidden> writes:
> [...]
>> Setting HGRCPATH was the result of some discussion on the list (here or
>> the bug list).
>>
>> We want to be able to reliably parse the results of hg log regardless
>> of the users .hgrc settings.
>
> In case my attached patch (re)creates any of the problems discussed back
> then I would be grateful for a pointer to the thread in question.
>
>>> So at the moment it looks as if the HGRCPATH='' can be simply removed!
>>
>> What happens if the user changes the format of hg log in her .hgrc ? 
>
> I see only two possible ways how this could happen: alias definitions
> (also redefining the original command name is discouraged) and default
> definitions (currently repriced in favor for aliases).
>
> My patch addresses them both...

> Sorry, but neither does Bug#5960 mention hgrc nor does the related patch
> include the hgrc related part.

It might have been another bug...


> So here is my patch, I successfully tested it with an "evil" hgrc
> redefining 'log' and 'parents'.  

How about testing with an hgrc that changes the defaults for log and parents?