Re: Patch to fix ERC mode's IRC protocol logging

[Michael Olson]

The patch looks good to me.  I'd say check it into Emacs (if you
haven't already done so) and send a courtesy copy to erc-discuss for
future patches.  The version of ERC in Emacs is probably going to be
the most canonical going forward, since it's the easiest to commit
changes to.

On Mon, Jul 19, 2010 at 8:22 PM, Deniz Dogan <address@hidden> wrote:
> 2010/7/20 Francis Litterio <address@hidden>:
>> Deniz Dogan wrote:
>>
>>> 2010/7/19 Fran Litterio:
>>> > The below patch fixes a problem in ERC where erc-toggle-debug-irc-protocol
>>> > was not logging inbound protocol data. It also changes the key to 
>>> > interactively
>>> > toggle protocol logging so that it doesn't interfere with View mode 
>>> > bindings.
>>
>>> Thank you! You should probably also send it to erc-discuss <at> gnu.org in
>>> case the ERC mantainer doesn't read emacs-devel.
>>
>> Do patches for ERC have to go into the upstream ERC source first in
>> order to make it into Emacs?  I thought that since ERC was now part of
>> Emacs, patches can go directly into the Emacs source.
>
> I guess I have the same understanding as you, but it may be more
> likely that you receive more feedback on the patch from erc-discuss.
>
> --
> Deniz Dogan
>
>



-- 
Michael Olson  |  http://mwolson.org/