Re: autoload cookies for defcustoms

[Wojciech Meyer]

Glenn Morris <address@hidden> writes:

> Wojciech Meyer wrote:
>
>> -;;;###autoload
>> +;; `defcustom' should not be autoloaded ;;;###autoload
>>  (defcustom holiday-general-holidays
>
> The remaining calendar autoloaded defcustoms are generally autoloaded
> for a reason, and I imagine the same is true in many other cases. Did
> you just do a blanket replace, or did you check every case?

Did a blanket replace. (however in the example you showed me I see some
toplevel code evaluated). It is up to maintainers what to do with the
patch, it just shows `defcustoms' with `autoload'. I might refine it if
somebody comes up with rules to follow.

This approach was due to:

> > Just curious.  Is there a policy, for the Lisp code distributed with
> > Emacs, about using autoload cookies for defcustoms? If so, what is it?

> AFAIK the policy is: "don't do it".
> It all too often introduces all kinds of nasty problems.
> More to the point, I welcome patches that remove tham.


>         Stefan

Cheers;
Wojciech