|
From: | Jan Djärv |
Subject: | Re: [Emacs-diffs] /srv/bzr/emacs/trunk r101633: Add fd handling with callbacks to select, dbus needs it for async operation. |
Date: | Sun, 26 Sep 2010 22:23:16 +0200 |
User-agent: | Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; sv-SE; rv:1.9.2.9) Gecko/20100915 Thunderbird/3.1.4 |
Eli Zaretskii skrev 2010-09-26 21.17:
Date: Sun, 26 Sep 2010 21:07:32 +0200 From: Jan Djärv<address@hidden> CC: address@hiddenThe changes that remove the "#ifdef subprocesses" conditionals will probably break the MSDOS build, because input_wait_mask etc. are only defined "#ifdef subprocesses". The functions add_keyboard_wait_descriptor and delete_keyboard_wait_descriptor are supposed to be no-ops for the MSDOS build.We need another ifdef then as dbus and for example session file descriptors have nothing to do with subprocesses. #ifndef MSDOS perhaps?The only Emacs build that doesn't have `subprocesses' #define'd is the MSDOS build. Using "#ifdef subprocesses" is just slightly less ugly then OS-dependent #define, but otherwise it is functionally identical to "#ifndef MSDOS". So I don't think we need another ifdef.
Ok, I put it back. Jan D.
[Prev in Thread] | Current Thread | [Next in Thread] |