[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Misleading `window-system' docstring
From: |
Eli Zaretskii |
Subject: |
Re: Misleading `window-system' docstring |
Date: |
Wed, 20 Oct 2010 20:20:14 +0200 |
> From: Štěpán Němec <address@hidden>
> Cc: Julien Danjou <address@hidden>, address@hidden
> Date: Wed, 20 Oct 2010 15:05:02 +0200
>
> Eli Zaretskii <address@hidden> writes:
>
> >> From: Julien Danjou <address@hidden>
> >> Cc: address@hidden
> >> Date: Tue, 19 Oct 2010 12:32:33 +0200
> >>
> >> + `(:eval (unless window-system
> >> + ,(propertize "-%-" 'help-echo help-echo)))))
> >
> > Using window-system is not right here, because the DOS port defines a
> > non-nil value, but uses a text terminal.
>
> Could you please fix the docstring of `window-system' to reflect that?
> It seems to be widely used that (incorrect, as you point out) way
Actually, there are only a handful of places that use it incorrectly.
Most of the uses compare its value with `x', `w32', etc., which is the
right usage.
> its docstring is pretty clear (and thus incorrect) on the matter:
>
> The value is nil if the selected frame is on a text-only-terminal.
I don't mind spelling out the exception, but I actually would like to
add there that using it as a predicate is deprecated, and point to
display-*-p predicates as TRT. Stefan and Chong, any objections?
- Dashes in mode-line, Julien Danjou, 2010/10/18
- Re: Dashes in mode-line, Eli Zaretskii, 2010/10/18
- Misleading `window-system' docstring (was Re: Dashes in mode-line), Štěpán Němec, 2010/10/20
- Re: Misleading `window-system' docstring,
Eli Zaretskii <=
- Re: Misleading `window-system' docstring, Chong Yidong, 2010/10/20
- Re: Misleading `window-system' docstring, Stefan Monnier, 2010/10/20
- Re: Misleading `window-system' docstring, Eli Zaretskii, 2010/10/22
Re: Dashes in mode-line, Deniz Dogan, 2010/10/19
Re: Dashes in mode-line, Deniz Dogan, 2010/10/19