|
From: | Ken Brown |
Subject: | Re: EMACS_GET_TTY_PGRP vs. emacs_get_tty_pgrp |
Date: | Wed, 20 Oct 2010 14:39:50 -0400 |
User-agent: | Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2.9) Gecko/20100915 Thunderbird/3.1.4 |
On 10/20/2010 11:14 AM, Andreas Schwab wrote:
Ken Brown<address@hidden> writes:The macro EMACS_GET_TTY_PGRP defined in src/systty.h uses either tcgetpgrp or TIOCGPGRP to get the PGID of a terminal's foreground process group. But src/process.c defines and uses its own emacs_get_tty_pgrp that only works on systems that have TIOCGPGRP. Is there a good reason for this?Is "historical accident" a good reason? :-)
Sure.It turned out that emacs_get_tty_pgrp has different arguments than its uppercase cousin, so I didn't get rid of it. But I used the macro inside the function instead and got rid of all ifdefs involving TIOCGPGRP. Does the attached patch look OK?
Ken
tty.patch
Description: Text document
[Prev in Thread] | Current Thread | [Next in Thread] |