Package menu not read-only

[Ralf Angeli]

Hi,

the buffer with the package menu (`M-x list-packages <RET>') is not
read-only.  The problem is due to `buffer-read-only' being set to nil in
`package--generate-package-list'.  This seems to be unnecessary because
`inhibit-read-only' is temporarily set to t anyway.  So I'd suggest the
following fix which I can apply if there are no objections.

--- lisp/emacs-lisp/package.el  2010-09-22 03:31:30 +0000
+++ lisp/emacs-lisp/package.el  2010-10-24 09:50:14 +0000
@@ -1474,7 +1474,6 @@
   (package-initialize)
   (let ((inhibit-read-only t)
        info-list name desc hold builtin)
-    (setq buffer-read-only nil)
     (erase-buffer)
     ;; List installed packages
     (dolist (elt package-alist)

I noticed the problem when typing <TAB> in the buffer in order to jump
to the next "link".  Apparently the package names are no links at all
and <TAB> does not make much sense here.  Wouldn't it be better from a
usability point of view to remove the underlining from the package
names?

In order to make it more apparent that commands in the buffer work on
whole lines and the horizontal position of point is not really relevant
one could also highlight the whole line in which point is located,
similar to what RefTeX does in table of contents (`C-c =' in a LaTeX
file).

-- 
Ralf