[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: GTK stack-busting loop
From: |
Stefan Monnier |
Subject: |
Re: GTK stack-busting loop |
Date: |
Sun, 31 Oct 2010 21:28:37 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) |
> *** src/xterm.c 2010-10-25 16:04:54 +0000
> --- src/xterm.c 2010-10-31 03:51:26 +0000
> ***************
> *** 7056,7062 ****
> }
> --handling_signal;
> ! UNBLOCK_INPUT;
> return count;
> }
> --- 7056,7062 ----
> }
> --handling_signal;
> ! --interrupt_input_blocked;
> return count;
> }
> Any thoughts? (Stefan?)
That doesn't sound very good.
There's nothing wrong (fundamentally) with the UNBLOCK_INPUT causing
another call to XTread_socket: after all, we've basically finished the
first call when we get to UNBLOCK_INPUT, so there's no "nested
interrupt" problem, AFAICT. After all, we're just coming out of
a "while (gtk_events_pending ())", so the case where we get "called
recursively" should be very rare.
I.e. I think this "problem" can only happen in bogus cases such as with
Gtk's bug.
Stefan