[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: theme and a question about creating them
From: |
Stefan Monnier |
Subject: |
Re: theme and a question about creating them |
Date: |
Thu, 20 Jan 2011 10:46:21 -0500 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) |
>> It doesn't make much sense to run the theme through `unsafep' while
>> marking `custom-theme-set-variables' and `custom-theme-set-faces' as
>> "safe functions" (which they aren't).
> A user who loads a theme would expects it to do *something*, so I'd
> argue that those two functions should not be considered unsafe while
> performing such an operation.
But if it sets a hook to trigger a nuclear explosion, the user might
be in for a nasty surprise.
> If this really is a concern, how bout marking only
> custom-theme-set-faces as safe? Then the user can be prompted for any
> (non-built-in) theme that changes variables, but themes that only
> fiddle with faces will be accepted.
I guess that one could be safe, tho IIRC we can set :height to
a function, so there's still a risk.
Stefan
- Re: theme and a question about creating them, (continued)
Re: theme and a question about creating them, Chong Yidong, 2011/01/05
Re: theme and a question about creating them, Chong Yidong, 2011/01/08