Re: bug in copy-directory

[Thierry Volpiatto]

Michael Albinus <address@hidden> writes:

> Thierry Volpiatto <address@hidden> writes:
>
>> Michael, could you apply the patch i sent here to Stefan and do:
>>
>> M-: (copy-directory "/tmp/test" "~/") RET
>>
>> You will see it works fine.
>
> Yes.
>
>> M-x copy-directory works fine too
>>
>> and copying from dired works fine also.
>
> Yes.
>
> However, when copying in dired "/tmp/test" to "~/", the second attempt
> results in a wrong directory structure.
Can't reproduce that here, all work fine from dired in emacs -Q
You can use also the unit-test i sent you, it exit with no failures.
(modify it a bit as code have changed now)


> For file name handlers your approach is a little bit, hmm, surprising.
> You call the handler for `copy-directory' inside of `copy-directory1'.
> This could work, or course, but it isn't a clean approach, and it will
> add a maintenance burden when all of us have forgotten what we are doing
> here.
Yes but copy-directory call copy-directory-1, so what's the problem?
file name handlers have to be in copy-directory-1 because dired MUST use
copy-directory-1 and not copy-directory.

> At least *I* am pretty good in forgetting (my wife says :-)
So nothing to remember, just use copy-directory as before. ;-)

-- 
A+ Thierry
Get my Gnupg key:
gpg --keyserver pgp.mit.edu --recv-keys 59F29997