Re: bug in copy-directory

[Michael Albinus]

Thierry Volpiatto <address@hidden> writes:


>> However, when copying in dired "/tmp/test" to "~/", the second attempt
>> results in a wrong directory structure.
> Can't reproduce that here, all work fine from dired in emacs -Q
> You can use also the unit-test i sent you, it exit with no failures.
> (modify it a bit as code have changed now)

Sorry, my bad. I've started the wrong Emacs instance. It works fine also
for me, all scenarios.

>> For file name handlers your approach is a little bit, hmm, surprising.
>> You call the handler for `copy-directory' inside of `copy-directory1'.
>> This could work, or course, but it isn't a clean approach, and it will
>> add a maintenance burden when all of us have forgotten what we are doing
>> here.
> Yes but copy-directory call copy-directory-1, so what's the problem?
> file name handlers have to be in copy-directory-1 because dired MUST use
> copy-directory-1 and not copy-directory.

Technically, there might be no problem. But it is unclean to call a file
name handler in a function which is not intended for. And also the
parameter lists differ between copy-directory and copy-directory1.

It's just a feeling that this kind of hacks could cause trouble in the
future. However, if Chong/Stefan do not oppose, I'll shut up and make
the changes in Tramp and ange-ftp.el.

Best regards, Michael.