emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] erc-track: fix tracking visibility issue


From: Michael Olson
Subject: Re: [PATCH] erc-track: fix tracking visibility issue
Date: Tue, 8 Feb 2011 16:45:10 -0800

Looks good to me.

On Mon, Feb 7, 2011 at 11:08 AM, Julien Danjou <address@hidden> wrote:
> This fix the tracking issue that when executing a command that change window
> configuration and may make a ERC buffer visible, ERC would consider it as
> read, which is not the case.
>
> Signed-off-by: Julien Danjou <address@hidden>
> ---
>  lisp/erc/ChangeLog    |   10 ++++++++++
>  lisp/erc/erc-track.el |   15 +++++++++++----
>  2 files changed, 21 insertions(+), 4 deletions(-)
>
> diff --git a/lisp/erc/ChangeLog b/lisp/erc/ChangeLog
> index ee81bc4..4f2a4c8 100644
> --- a/lisp/erc/ChangeLog
> +++ b/lisp/erc/ChangeLog
> @@ -1,3 +1,13 @@
> +2011-02-07  Julien Danjou  <address@hidden>
> +
> +       * erc-track.el (erc-window-configuration-change): New
> +       function. This will allow to track buffer visibility when a
> +       command is finished to executed. Idea stolen from rcirc.
> +       (track): Put erc-window-configuration-change in
> +       window-configuration-change-hook.
> +       (erc-modified-channels-update): Remove
> +       erc-modified-channels-update from post-command-hook after update.
> +
>  2011-01-31  Antoine Levitt  <address@hidden>  (tiny change)
>
>        * erc-track.el (track): Don't reset erc-modified-channels-object
> diff --git a/lisp/erc/erc-track.el b/lisp/erc/erc-track.el
> index de920eb..a89244f 100644
> --- a/lisp/erc/erc-track.el
> +++ b/lisp/erc/erc-track.el
> @@ -653,7 +653,7 @@ module, otherwise the keybindings will not do anything 
> useful."
>           (defadvice switch-to-buffer (after erc-update (&rest args) activate)
>             (erc-modified-channels-update))
>         (add-hook 'window-configuration-change-hook
> -                  'erc-modified-channels-update))
> +                  'erc-window-configuration-change))
>        (add-hook 'erc-insert-post-hook 'erc-track-modified-channels)
>        (add-hook 'erc-disconnected-hook 'erc-modified-channels-update))
>      ;; enable the tracking keybindings
> @@ -675,7 +675,7 @@ module, otherwise the keybindings will not do anything 
> useful."
>        (if (featurep 'xemacs)
>           (ad-disable-advice 'switch-to-buffer 'after 'erc-update)
>         (remove-hook 'window-configuration-change-hook
> -                     'erc-modified-channels-update))
> +                     'erc-window-configuration-change))
>        (remove-hook 'erc-disconnected-hook 'erc-modified-channels-update)
>        (remove-hook 'erc-insert-post-hook 'erc-track-modified-channels))
>      ;; disable the tracking keybindings
> @@ -730,6 +730,12 @@ only consider active buffers visible.")
>
>  ;;; Tracking the channel modifications
>
> +(defun erc-window-configuration-change ()
> +  (unless (minibuffer-window-active-p (minibuffer-window))
> +    ;; delay this until command has finished to make sure window is
> +    ;; actually visible before clearing activity
> +    (add-hook 'post-command-hook 'erc-modified-channels-update)))
> +
>  (defvar erc-modified-channels-update-inside nil
>   "Variable to prevent running `erc-modified-channels-update' multiple
>  times.  Without it, you cannot debug `erc-modified-channels-display',
> @@ -757,8 +763,9 @@ ARGS are ignored."
>                  (erc-modified-channels-remove-buffer buffer))))
>            erc-modified-channels-alist)
>       (when removed-channel
> -      (erc-modified-channels-display)
> -       (force-mode-line-update t)))))
> +       (erc-modified-channels-display)
> +       (force-mode-line-update t)))
> +    (remove-hook 'post-command-hook 'erc-modified-channels-update)))
>
>  (defvar erc-track-mouse-face (if (featurep 'xemacs)
>                                 'modeline-mousable
> --
> 1.7.2.3
>
>
>



-- 
Michael Olson  |  http://mwolson.org/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]