[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] delete-trailing-whitespace on active region
From: |
Deniz Dogan |
Subject: |
Re: [PATCH] delete-trailing-whitespace on active region |
Date: |
Thu, 10 Feb 2011 16:31:36 +0100 |
2011/2/10 Stefan Monnier <address@hidden>:
>> + (interactive "*r")
>
> Using "r" and then checking region-active-p sounds clever, but is wrong:
> - "r" will fail if the mark has never been set in the current buffer.
> - checking region-active-p is wrong in non-interactive use.
> I.e. the `interactive' spec should do the region-active-p check.
> Oh, and it should use use-region-p instead of region-active-p.
>
Thanks for the review
Attached is a reworked patch. Is it better now?
--
Deniz Dogan
dtw2.patch
Description: Binary data
- [PATCH] delete-trailing-whitespace on active region, Deniz Dogan, 2011/02/09
- Re: [PATCH] delete-trailing-whitespace on active region, Stefan Monnier, 2011/02/09
- Re: [PATCH] delete-trailing-whitespace on active region,
Deniz Dogan <=
- Re: [PATCH] delete-trailing-whitespace on active region, Stefan Monnier, 2011/02/10
- Re: [PATCH] delete-trailing-whitespace on active region, Johan Bockgård, 2011/02/10
- Re: [PATCH] delete-trailing-whitespace on active region, Stefan Monnier, 2011/02/10
- Re: [PATCH] delete-trailing-whitespace on active region, Deniz Dogan, 2011/02/11
- Re: [PATCH] delete-trailing-whitespace on active region, Stefan Monnier, 2011/02/11
- Re: [PATCH] delete-trailing-whitespace on active region, Deniz Dogan, 2011/02/11