[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: bug: epg send unencrypted data in trash
From: |
Chong Yidong |
Subject: |
Re: bug: epg send unencrypted data in trash |
Date: |
Fri, 11 Feb 2011 19:23:06 -0500 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) |
Ted Zlatanov <address@hidden> writes:
> On Fri, 11 Feb 2011 22:05:09 +0100 Thierry Volpiatto
> <address@hidden> wrote:
>
> TV> Ted Zlatanov <address@hidden> writes:
>>> According to the docs for `delete-file' it shouldn't matter what
>>> `delete-by-moving-to-trash' says because this is called
>>> non-interactively (TRASH is nil when delete-file is called
>>> non-interactively). Or is this funcall interactive somehow?
> TV> I don't know, but actually without delete-by-moving-to-trash let-bound
> TV> to nil, non--encrypted data goes to trash.
>
> I think this is because in the C source (fileio.c) TRASH is set to
> "(null current-prefix-arg)" which is not equivalent to
> `called-interactively-p' AFAIK. IOW I think your fix is masking the
> underlying problem. But I don't know the C source so well so I could be
> misunderstanding things. Perhaps Chong Yidong, who created revision
> 100462 and introduced the TRASH parameter, can check it.
I think TV is using the emacs-23 branch, where the TRASH parameter is
not present. I've changed EPA and EPG to bind delete-by-moving-to-trash
to nil there. No fix is necessary for the trunk, IIUC.
- bug: epg send unencrypted data in trash, Thierry Volpiatto, 2011/02/11
- Re: bug: epg send unencrypted data in trash, Thierry Volpiatto, 2011/02/11
- Re: bug: epg send unencrypted data in trash, Ted Zlatanov, 2011/02/11
- Re: bug: epg send unencrypted data in trash, Thierry Volpiatto, 2011/02/11
- Re: bug: epg send unencrypted data in trash, Ted Zlatanov, 2011/02/11
- Re: bug: epg send unencrypted data in trash,
Chong Yidong <=
- Re: bug: epg send unencrypted data in trash, Thierry Volpiatto, 2011/02/12
- Re: bug: epg send unencrypted data in trash, Ted Zlatanov, 2011/02/12
- Re: bug: epg send unencrypted data in trash, Chong Yidong, 2011/02/12
- Re: bug: epg send unencrypted data in trash, Ted Zlatanov, 2011/02/12