Re: bug in copy-directory

[Michael Albinus]

Thierry Volpiatto <address@hidden> writes:

> Chong Yidong <address@hidden> writes:
>
>> Thierry Volpiatto <address@hidden> writes:
>>
>>> Michael Albinus <address@hidden> writes:
>>>
>>>>> (defun copy-directory (directory newname &optional keep-time
>>>> parents copy-contents-only)
>>>>
>>>> I'm in favor of this proposal (compared with the recently introduced
>>>> `copy-as-subdir'). Thierry's proposal keeps the semantics of
>>>> `copy-directory', and the changed semantics are activated by the
>>>> optional argument.
>>>
>>> So when everybody is ok, i can send patch with this modification.
>>> Tell me also if copy-contents-only as arg name is ok for you (if you
>>> have better idea i take).
>>
>> This is OK for the trunk.  If we go this route, I'd prefer to revert the
>> branch to the Emacs 23.2 behavior, since it requires non-local changes
>> and is backward incompatible; then we'll make the change for Emacs 24.
> ???I would say revert to Emacs 23.2 bug...

Thierry's patch, removing the recently introduced `copy-as-subdir',
could go into Emacs 23.3 IMHO. The extension `copy-contents-only' shall
be applied in the trunk.

Best regards, Michael.