emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Passing flags using vc-do-command


From: Stefan Monnier
Subject: Re: Passing flags using vc-do-command
Date: Mon, 14 Mar 2011 09:43:50 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux)

> + (defvar vc-post-command-1-functions nil
> +   "Hook run at the end of `vc-do-command-1'.
> + Each function is called inside the buffer in which the command
> + was run and is passed 4 arguments: the COMMAND, the FILE-OR-LIST,
> + the BEFORE-FLAGS and the AFTER-FLAGS.")

Do we really need that?

> ! (defun vc-do-command-1 (buffer okstatus command file-or-list
> !                     &optional before-flag-or-list &rest after-flags)

I'd rather a nicer name for the new command.
And I'd like it to address some of the other needs of backends,
e.g. paying attention to vc-<backend>-program.  So I think we should
look at the calls to vc-do-command (and to
call-process/start-process/...) in backends to try and design the
successor to vc-do-command.


        Stefan



reply via email to

[Prev in Thread] Current Thread [Next in Thread]