Re: ERC tracking broken

[Antoine Levitt]

29/03/11 23:20, Stefan Monnier
>> ERC tracking seems to be broken. Reverting to the binary of emacs I
>> compiled yesterday fixes it, so I strongly suspect it's a result of
>
>> commit 5e4cb836580a8ef2f9ea9b4b8317005941920027
>> Author: Stefan Monnier <address@hidden>
>> Date:   Mon Mar 28 16:26:35 2011 -0400
>>     Don't reset post-command-hook to nil upon error.
>
>> which interferes with a patch by Julien Danjou about using
>> post-command-hook to notice window changes in erc-track.  I don't
>> remember the specifics though.
>
> My change should not affect the behavior of post-command-hook expect
> when one of the hook functions signals an error (something that should
> not happen, normally), so if it's due to my change, it's a bug in
> my change.
>
> Do you have a recipe to reproduce the problem, starting from "emacs -Q"
> (including for someone like me who basically never used IRC)?
>
>
>         Stefan

Alright, I finally traced it back to something not ERC-related. The
easiest way I could reproduce it is with some code to highlight
parentheses. So here's a simple recipe:

- Get http://pastebin.com/UafFZ9qy and put it in your load path (I got
  this code from emacswiki some time ago, it worked fine until today -
  which doesn't mean it's correct, maybe your changes simply exposed a
  bug in it)

- Put

(require 'highlight-parentheses)
(global-highlight-parentheses-mode t)
(ido-mode 1)
(icomplete-mode 1)

in a blank .emacs

- M-x a, observe there's a nice completion list
- C-g to get out of the completion
- M-x a, observe the completion list has disappeared (for the rest
  of the session)

This started occuring at some point today and the code uses
post-command-hook, so it's probably related.

Hope that helps

Antoine